Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bytes_per_second to copy_if_else benchmark #13960

Merged
merged 3 commits into from
Aug 30, 2023
Merged

Add bytes_per_second to copy_if_else benchmark #13960

merged 3 commits into from
Aug 30, 2023

Conversation

Blonck
Copy link
Contributor

@Blonck Blonck commented Aug 25, 2023

Adds bytes_per_second to the COPY_IF_ELSE_BENCH benchmark.

This patch relates to #13735.

Checklist

Add bytes_per_second to copy_if_else benchmark
808fdc1 
Adds `bytes_per_second to `COPY_IF_ELSE_BENCH`.

This patch relates to rapidsai#13735.
@Blonck Blonck requested a review from a team as a code owner August 25, 2023 13:50
@Blonck Blonck requested review from vyasr and bdice August 25, 2023 13:50
@rapids-bot
Copy link

rapids-bot bot commented Aug 25, 2023

Pull requests from external contributors require approval from a rapidsai organization member with write permissions or greater before CI can begin.

@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Aug 25, 2023
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 25, 2023
@davidwendt
Copy link
Contributor

/ok to test

bdice
bdice approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@davidwendt
Copy link
Contributor

/ok to test

@copy-pr-bot
Copy link

copy-pr-bot bot commented Aug 30, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@davidwendt
Copy link
Contributor

/ok to test

@bdice
Copy link
Contributor

bdice commented Aug 30, 2023

/merge

@rapids-bot rapids-bot bot merged commit 9259a20 into rapidsai:branch-23.10 Aug 30, 2023
@GregoryKimball GregoryKimball mentioned this pull request Nov 3, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwendt davidwendt davidwendt approved these changes

@bdice bdice bdice approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Blonck @davidwendt @bdice